hotfix: remove opportunity status_match column from migration#424
Draft
hotfix: remove opportunity status_match column from migration#424
Conversation
Adding status_match to the opportunity table via raw SQL bypassed the TypeORM entity/DTO layer and used the wrong enum type (volunteer_status_match_enum instead of an opportunity-specific enum). Removed the ALTER TABLE ADD COLUMN and the opportunity status_match recalculation UPDATE from the data migration. This needs to be implemented properly through the entity and DTO layer. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ALTER TABLE public.opportunity ADD COLUMN status_matchfrom migration1777383134500— the column was added with the wrong enum type (volunteer_status_match_enuminstead of an opportunity-specific enum) and bypassed the TypeORM entity/DTO layer entirelyopportunity.status_matchrecalculationUPDATEfrom the data migration1777384229791— it references the column that no longer existsstatusMatchon the opportunity entity needs to be properly implemented through the TypeORM entity, DTO, and schema layer with the correct enum typeTest plan
🤖 Generated with Claude Code